Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overhaul search with a Command Palette #7569

Open
wants to merge 135 commits into
base: master
Choose a base branch
from
Open

Overhaul search with a Command Palette #7569

wants to merge 135 commits into from

Conversation

janfaracik
Copy link
Contributor

@janfaracik janfaracik commented Jan 6, 2023 •
edited
Loading

image

image

This PR introduces the Command Palette concept to Jenkins, first discussed back in the day in the November 2021 UX SIG meeting. You've probably used something similar if you've used VS Code, Jenkins.io, GitHub, Spotify etc. They're handy overlays that allow you to quickly use your keyboard to navigate, be that searching for different pages or finding functions in menus.

This is an early implementation and as such doesn't have all the features I want it to have, such as grouped results, icons and richer details for results, all aimed at making the search experience in Jenkins easier to use. I'd also like for plugin developers to eventually be able to integrate with the Command Palette so they can provide their own rich results/actions, for example being able to change theme from the palette.

Testing done

  • Clicking the search button shows the Command Palette
  • CMD + K shows the Command Palette
  • Searching for terms brings up identical results to the previous search bar

Proposed changelog entries

  • Add Command Palette as replacement for search bar

Proposed upgrade guidelines

N/A

Submitter checklist

  • The Jira issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples).
    • Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
  • There is automated testing or an explanation as to why this change has no tests.
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
  • New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
  • New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
  • For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@jenkinsci/sig-ux

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@janfaracik
Squashed commit of the following:
1b37f3e 
commit f6fd421
Merge: 0da81bd e7b46e9
Author: Jan Faracik <[email protected]>
Date:   Wed Dec 21 00:34:06 2022 +0000

    Merge branch 'master' into search-overhaul

commit 0da81bd
Author: Jan Faracik <[email protected]>
Date:   Sat Dec 3 22:15:11 2022 +0000

    Merge in master

commit ace2138
Merge: 0308dd6 d3d1c88
Author: Jan Faracik <[email protected]>
Date:   Sat Dec 3 21:52:15 2022 +0000

    Merge branch 'master' into search-overhaul

commit 0308dd6
Merge: 6c4d2c8 06d0ce8
Author: Jan Faracik <[email protected]>
Date:   Fri Oct 21 23:01:22 2022 +0100

    Merge branch 'master' into search-overhaul

commit 6c4d2c8
Author: Jan Faracik <[email protected]>
Date:   Sun Oct 2 12:51:36 2022 +0100

    Fix shortcut, add more categories

commit 2a8642d
Author: Jan Faracik <[email protected]>
Date:   Sat Oct 1 16:58:15 2022 +0100

    Remove sidebar source

commit d77c2dd
Author: Jan Faracik <[email protected]>
Date:   Sat Oct 1 16:52:52 2022 +0100

    Linting

commit 113aa94
Author: Jan Faracik <[email protected]>
Date:   Sat Oct 1 16:48:28 2022 +0100

    Improve appearance, use vars, improve animations

commit 8004e77
Author: Jan Faracik <[email protected]>
Date:   Sat Oct 1 16:01:49 2022 +0100

    Update side-panel-tasks.less

commit e7d2391
Merge: 8100f56 37749a7
Author: Jan Faracik <[email protected]>
Date:   Sat Oct 1 16:00:17 2022 +0100

    Merge branch 'master' into search-overhaul

commit 8100f56
Author: Jan Faracik <[email protected]>
Date:   Wed Aug 10 19:27:37 2022 +0100

    Update command-palette.jelly

commit 6ce62f0
Merge: 9bbb282 f6daa76
Author: Jan Faracik <[email protected]>
Date:   Wed Aug 10 19:27:22 2022 +0100

    Merge branch 'new-search-bar-component' into search-overhaul

commit f6daa76
Author: Jan Faracik <[email protected]>
Date:   Wed Aug 10 19:27:12 2022 +0100

    Update search-bar.jelly

commit 9bec29f
Author: Jan Faracik <[email protected]>
Date:   Wed Aug 10 19:26:18 2022 +0100

    Update search-bar.jelly

commit afebc6f
Author: Jan Faracik <[email protected]>
Date:   Wed Aug 10 19:24:51 2022 +0100

    Update search-bar.less

commit 9bbb282
Merge: c13c34e f97ff09
Author: Jan Faracik <[email protected]>
Date:   Wed Aug 10 19:19:44 2022 +0100

    Merge branch 'new-search-bar-component' into search-overhaul

commit f97ff09
Author: Jan Faracik <[email protected]>
Date:   Wed Aug 10 19:19:32 2022 +0100

    Update search-bar.less

commit c13c34e
Author: Jan Faracik <[email protected]>
Date:   Wed Aug 10 14:46:22 2022 +0100

    Use search bar component

commit c664816
Merge: b593d92 77e62b8
Author: Jan Faracik <[email protected]>
Date:   Tue Aug 9 23:30:32 2022 +0100

    Merge branch 'new-search-bar-component' into search-overhaul

commit b593d92
Author: Jan Faracik <[email protected]>
Date:   Tue Aug 9 23:30:02 2022 +0100

    Linting

commit 21d825c
Merge: 702bb2a f5d7165
Author: Jan Faracik <[email protected]>
Date:   Tue Aug 9 23:10:32 2022 +0100

    Merge branch 'master' into search-overhaul

commit 77e62b8
Author: Jan Faracik <[email protected]>
Date:   Tue Aug 9 22:02:13 2022 +0100

    Linting

commit 60d6a7f
Merge: 591e983 f5d7165
Author: Jan Faracik <[email protected]>
Date:   Tue Aug 9 21:56:52 2022 +0100

    Merge branch 'master' into new-search-bar-component

commit 591e983
Merge: 6cfce9f ef7f408
Author: Jan Faracik <[email protected]>
Date:   Mon Jul 25 21:04:10 2022 +0100

    Merge branch 'master' into new-search-bar-component

commit 6cfce9f
Author: Jan Faracik <[email protected]>
Date:   Thu Jul 21 22:41:27 2022 +0100

    Replace plugin manager search with new search component

commit 95922de
Merge: 65f7cd3 09eb5f1
Author: Jan Faracik <[email protected]>
Date:   Thu Jul 21 22:32:05 2022 +0100

    Merge branch 'new-plugin-manager-1' into new-search-bar-component

commit 65f7cd3
Author: Jan Faracik <[email protected]>
Date:   Thu Jul 21 22:31:54 2022 +0100

    Add autofocus

commit 1db67ab
Author: Jan Faracik <[email protected]>
Date:   Thu Jul 21 18:06:20 2022 +0100

    Update Jenkins search bar style

commit 83e4b12
Author: Jan Faracik <[email protected]>
Date:   Thu Jul 21 17:16:57 2022 +0100

    Add keyboard shortcut symbol

commit 1f5c74e
Merge: 9878cac 6f7a259
Author: Jan Faracik <[email protected]>
Date:   Thu Jul 21 16:31:30 2022 +0100

    Merge branch 'add-search-keyboard-shortcut' into new-search-bar-component

commit 6f7a259
Author: Jan Faracik <[email protected]>
Date:   Thu Jul 21 16:31:09 2022 +0100

    Update keyboard-shortcuts.js

commit 9b10a2d
Author: Jan Faracik <[email protected]>
Date:   Thu Jul 21 15:33:21 2022 +0100

    Update yarn.lock

commit fac0b6f
Merge: 9654bfb bcefcc5
Author: Jan Faracik <[email protected]>
Date:   Thu Jul 21 14:56:29 2022 +0100

    Merge branch 'master' into add-search-keyboard-shortcut

commit 9654bfb
Author: Jan Faracik <[email protected]>
Date:   Thu Jul 21 14:51:01 2022 +0100

    Update

commit f2a6e56
Author: Jan Faracik <[email protected]>
Date:   Wed Jul 20 22:31:38 2022 +0100

    Add iPhone to use CMD key check

commit ce21573
Merge: cb34850 588ccd6
Author: Jan Faracik <[email protected]>
Date:   Wed Jul 20 21:39:18 2022 +0100

    Merge branch 'master' into add-search-keyboard-shortcut

commit cb34850
Merge: db5612a 237b9ca
Author: Jan Faracik <[email protected]>
Date:   Wed Jul 20 21:34:32 2022 +0100

    Merge branch 'master' into add-search-keyboard-shortcut

commit 9878cac
Author: Jan Faracik <[email protected]>
Date:   Wed Jul 20 21:24:27 2022 +0100

    Update search-bar.jelly

commit 930166b
Merge: d584d0f 237b9ca
Author: Jan Faracik <[email protected]>
Date:   Wed Jul 20 19:12:44 2022 +0100

    Merge branch 'master' into new-search-bar-component

commit 09eb5f1
Merge: b8880ed 7509a69
Author: Jan Faracik <[email protected]>
Date:   Mon Jul 18 21:58:09 2022 +0100

    Merge branch 'master' into new-plugin-manager-1

commit b8880ed
Author: Jan Faracik <[email protected]>
Date:   Mon Jul 18 14:55:39 2022 +0100

    Fix checkbox controller selection

commit 0b808b0
Merge: 4d640b4 38d4e86
Author: Jan Faracik <[email protected]>
Date:   Mon Jul 18 14:50:01 2022 +0100

    Merge branch 'master' into new-plugin-manager-1

commit 4d640b4
Merge: e14b7d2 f52d99a
Author: Tim Jacomb <[email protected]>
Date:   Thu Jul 14 09:01:42 2022 +0100

    Merge branch 'master' into new-plugin-manager-1

commit d584d0f
Author: Jan Faracik <[email protected]>
Date:   Wed Jul 13 23:38:19 2022 +0100

    Init

commit e14b7d2
Merge: 0f2ef2f a990ebc
Author: Jan Faracik <[email protected]>
Date:   Tue Jul 12 23:24:54 2022 +0100

    Merge branch 'master' into new-plugin-manager-1

commit db5612a
Author: Jan Faracik <[email protected]>
Date:   Tue Jul 12 22:12:00 2022 +0100

    Squashed commit of the following:

    commit b775940
    Author: Jan Faracik <[email protected]>
    Date:   Tue Jul 12 22:10:40 2022 +0100

        Update package

    commit 8191583
    Author: Jan Faracik <[email protected]>
    Date:   Tue Jul 12 22:04:31 2022 +0100

        Update headerContent.jelly

    commit 0f9f7c6
    Author: Jan Faracik <[email protected]>
    Date:   Tue Jul 12 22:03:37 2022 +0100

        Remove core-js dependency

    commit c6bb510
    Author: Jan Faracik <[email protected]>
    Date:   Tue Jul 12 21:55:29 2022 +0100

        Minimize code just for search bar

    commit 47ccdfb
    Author: Jan Faracik <[email protected]>
    Date:   Tue Jul 12 21:37:27 2022 +0100

        Reset more files

    commit b710e4d
    Author: Jan Faracik <[email protected]>
    Date:   Tue Jul 12 21:36:23 2022 +0100

        Reset

    commit 3da7082
    Author: Jan Faracik <[email protected]>
    Date:   Tue Jul 12 21:31:30 2022 +0100

        Add console warning for duplicated registrations

    commit 4dbc2e3
    Merge: 413eff2 76481f4
    Author: Jan Faracik <[email protected]>
    Date:   Tue Jul 12 16:37:16 2022 +0100

        Merge branch 'master' into keyboard-shortcuts

    commit 413eff2
    Merge: 80bee75 77a36fc
    Author: Jan Faracik <[email protected]>
    Date:   Fri Jun 3 23:10:07 2022 +0100

        Merge branch 'master' into keyboard-shortcuts

    commit 80bee75
    Author: Jan Faracik <[email protected]>
    Date:   Fri May 13 22:24:06 2022 +0100

        Update styles.less

    commit 875c93e
    Author: Jan Faracik <[email protected]>
    Date:   Fri May 13 22:23:34 2022 +0100

        Update keyboard-shortcuts.less

    commit 1b6391c
    Author: Jan Faracik <[email protected]>
    Date:   Fri May 13 22:17:13 2022 +0100

        Update keyboard-shortcuts.js

    commit c828d87
    Author: Jan Faracik <[email protected]>
    Date:   Fri May 13 22:16:57 2022 +0100

        Update keyboard-shortcuts.js

    commit 7ad4b6f
    Author: Jan Faracik <[email protected]>
    Date:   Fri May 13 22:14:47 2022 +0100

        Updated comments, remove unneeded dependency

    commit 9d7abbb
    Author: Jan Faracik <[email protected]>
    Date:   Fri May 13 22:04:07 2022 +0100

        Cleanup

    commit 76702be
    Author: Jan Faracik <[email protected]>
    Date:   Fri May 13 22:02:02 2022 +0100

        Update yarn.lock

    commit ea0e439
    Merge: 8d1112d e128402
    Author: Jan Faracik <[email protected]>
    Date:   Fri May 13 22:01:17 2022 +0100

        Merge branch 'master' into keyboard-shortcuts

    commit 8d1112d
    Author: Jan Faracik <[email protected]>
    Date:   Fri May 13 22:01:05 2022 +0100

        Isolate out tooltip changes

    commit 76fc089
    Merge: 7d7cd05 bbd7ca2
    Author: Jan Faracik <[email protected]>
    Date:   Fri May 13 21:42:05 2022 +0100

        Merge branch 'master' into keyboard-shortcuts

    commit 7d7cd05
    Author: Jan Faracik <[email protected]>
    Date:   Fri May 13 21:41:42 2022 +0100

        Update buildHealth.jelly

    commit 7ed6ff0
    Merge: 7bce4da c350527
    Author: Jan Faracik <[email protected]>
    Date:   Thu Apr 28 20:21:45 2022 +0100

        Merge branch 'master' into keyboard-shortcuts

    commit 7bce4da
    Author: Jan Faracik <[email protected]>
    Date:   Sat Apr 16 10:59:03 2022 +0100

        Add more shortcuts, add animation on key press

    commit 07b741b
    Author: Jan Faracik <[email protected]>
    Date:   Sat Apr 16 01:12:22 2022 +0100

        Add animation for selected key

    commit ce644cb
    Author: Jan Faracik <[email protected]>
    Date:   Sat Apr 16 00:47:45 2022 +0100

        Add keyboard shortcuts

    commit 34d6c89
    Merge: dd5b905 4a38d65
    Author: Jan Faracik <[email protected]>
    Date:   Sat Apr 16 00:40:41 2022 +0100

        Merge branch 'master' into keyboard-shortcuts

    commit dd5b905
    Author: Jan Faracik <[email protected]>
    Date:   Tue Mar 29 01:13:57 2022 +0100

        Add jelly component

    commit 959f586
    Merge: 54b47b5 32d790a
    Author: Jan Faracik <[email protected]>
    Date:   Mon Mar 28 23:51:43 2022 +0100

        Merge branch 'tippy-1-tooltip' into keyboard-shortcuts

    commit 54b47b5
    Author: Jan Faracik <[email protected]>
    Date:   Mon Mar 28 23:47:13 2022 +0100

        Reset further

    commit b580312
    Author: Jan Faracik <[email protected]>
    Date:   Mon Mar 28 23:46:01 2022 +0100

        Reset to master

    commit 32d790a
    Author: Jan Faracik <[email protected]>
    Date:   Mon Mar 28 14:06:21 2022 +0100

        Now possible to reregister tooltips for a specific container

    commit d5608a1
    Author: Jan Faracik <[email protected]>
    Date:   Mon Mar 28 13:16:30 2022 +0100

        Fix new line in queue tooltip

    commit f7659aa
    Author: Jan Faracik <[email protected]>
    Date:   Sun Mar 27 23:34:25 2022 +0100

        Fix last build successful from having a title

    commit bfce09a
    Author: Jan Faracik <[email protected]>
    Date:   Sun Mar 27 23:31:31 2022 +0100

        Fix new lines in tooltips, fix empty tooltips showing

    commit c58eb41
    Author: Jan Faracik <[email protected]>
    Date:   Fri Mar 25 14:27:13 2022 +0000

        Update keyboard shortcut logic

    commit b330661
    Author: Jan Faracik <[email protected]>
    Date:   Thu Mar 24 23:15:30 2022 +0000

        Initial commit, working search overlay

    commit 93632d3
    Merge: 60e4232 5144035
    Author: Jan Faracik <[email protected]>
    Date:   Tue Mar 22 09:52:43 2022 +0000

        Merge branch 'master' into tippy-1-tooltip

    commit 60e4232
    Author: Jan Faracik <[email protected]>
    Date:   Fri Mar 18 00:31:41 2022 +0000

        Update tooltips.js

    commit 9be65d6
    Author: Jan Faracik <[email protected]>
    Date:   Fri Mar 18 00:30:14 2022 +0000

        Update prototype.js

    commit 22f300a
    Merge: 7223890 422efe9
    Author: Jan Faracik <[email protected]>
    Date:   Thu Mar 17 20:40:32 2022 +0000

        Merge branch 'master' into tippy-1-tooltip

    commit 7223890
    Author: Jan Faracik <[email protected]>
    Date:   Tue Mar 15 13:28:35 2022 +0000

        Add percentage symbol

    commit 133c486
    Author: Jan Faracik <[email protected]>
    Date:   Tue Mar 15 09:51:35 2022 +0000

        Update header tooltips, add base tooltip styling

    commit 7e43dfa
    Author: Jan Faracik <[email protected]>
    Date:   Tue Mar 15 01:27:16 2022 +0000

        Update buildHealth.jelly

    commit df6847a
    Author: Jan Faracik <[email protected]>
    Date:   Tue Mar 15 01:25:16 2022 +0000

        Now possible to reregister tooltips

    commit 7e6c576
    Author: Jan Faracik <[email protected]>
    Date:   Tue Mar 15 01:15:10 2022 +0000

        Fix tooltip showing when it shouldn't, improve appearance

    commit 940d51a
    Author: Jan Faracik <[email protected]>
    Date:   Tue Mar 15 00:47:18 2022 +0000

        WB

    commit 1fbcc55
    Author: Jan Faracik <[email protected]>
    Date:   Tue Mar 15 00:38:20 2022 +0000

        Update tooltips.less

    commit 491b1f1
    Author: Jan Faracik <[email protected]>
    Date:   Tue Mar 15 00:36:07 2022 +0000

        Update hudson-behavior.js

    commit 09e9109
    Author: Jan Faracik <[email protected]>
    Date:   Tue Mar 15 00:33:13 2022 +0000

        WB

    commit db1928d
    Author: Jan Faracik <[email protected]>
    Date:   Tue Mar 15 00:24:10 2022 +0000

        Add initial JS files

    commit 0ff896b
    Author: Jan Faracik <[email protected]>
    Date:   Tue Mar 15 00:20:38 2022 +0000

        Add yarn deps

commit 0f2ef2f
Merge: db677f3 22dcefc
Author: Jan Faracik <[email protected]>
Date:   Thu Jul 7 13:48:53 2022 +0100

    Merge branch 'master' into new-plugin-manager-1

commit 702bb2a
Author: Jan Faracik <[email protected]>
Date:   Wed Jul 6 17:29:10 2022 +0100

    Revamp search styling

commit fba08e7
Merge: 494f551 644a261
Author: Jan Faracik <[email protected]>
Date:   Wed Jul 6 16:20:38 2022 +0100

    Merge branch 'master' into search-overhaul

commit db677f3
Merge: 6e64c68 644a261
Author: Jan Faracik <[email protected]>
Date:   Wed Jul 6 13:37:57 2022 +0100

    Merge branch 'master' into new-plugin-manager-1

commit 6e64c68
Merge: dbc96f4 250540e
Author: Tim Jacomb <[email protected]>
Date:   Wed Jul 6 07:48:54 2022 +0100

    Merge branch 'master' into new-plugin-manager-1

commit dbc96f4
Merge: d74aeae 2b83c2e
Author: Tim Jacomb <[email protected]>
Date:   Wed Jul 6 06:43:36 2022 +0100

    Merge branch 'master' into new-plugin-manager-1

commit d74aeae
Author: Jan Faracik <[email protected]>
Date:   Tue Jul 5 23:29:13 2022 +0100

    Remove unused page variable

commit 9f3c69c
Merge: a46beb7 4ba9c08
Author: Jan Faracik <[email protected]>
Date:   Tue Jul 5 23:10:31 2022 +0100

    Merge branch 'master' into new-plugin-manager-1

commit a46beb7
Author: Jan Faracik <[email protected]>
Date:   Tue Jul 5 17:39:32 2022 +0100

    Improve visibility of search bar

commit a688b3b
Author: Jan Faracik <[email protected]>
Date:   Tue Jul 5 17:11:11 2022 +0100

    Restore tab bar

commit a39862c
Merge: 87c27c2 76e5c98
Author: Jan Faracik <[email protected]>
Date:   Tue Jul 5 17:08:02 2022 +0100

    Merge branch 'master' into new-plugin-manager-1

commit 87c27c2
Author: Jan Faracik <[email protected]>
Date:   Mon Jun 20 11:42:19 2022 +0100

    Update side-panel-tasks.less

commit abcbecf
Author: Jan Faracik <[email protected]>
Date:   Sun Jun 19 22:42:50 2022 +0100

    Update search bar

commit 88b2a59
Merge: f89fe63 2391319
Author: Jan Faracik <[email protected]>
Date:   Sun Jun 19 22:37:53 2022 +0100

    Merge branch 'move-manage-jenkins-less' into new-plugin-manager-1

commit 2391319
Merge: c9e2823 ac66b47
Author: Jan Faracik <[email protected]>
Date:   Thu Jun 16 17:47:45 2022 +0100

    Merge branch 'master' into move-manage-jenkins-less

commit c9e2823
Author: Jan Faracik <[email protected]>
Date:   Thu Jun 16 17:35:37 2022 +0100

    Update colors

commit c78dfd6
Author: Jan Faracik <[email protected]>
Date:   Thu Jun 16 17:33:47 2022 +0100

    Update theme.less

commit 0996e75
Author: Jan Faracik <[email protected]>
Date:   Thu Jun 16 17:32:52 2022 +0100

    Update theme.less

commit e57bc28
Author: Jan Faracik <[email protected]>
Date:   Thu Jun 16 17:29:15 2022 +0100

    Update theme.less

commit 69c1633
Author: Jan Faracik <[email protected]>
Date:   Thu Jun 16 17:00:06 2022 +0100

    Update style.less

commit e21d4e7
Author: Jan Faracik <[email protected]>
Date:   Wed Jun 15 19:03:50 2022 +0100

    Update breadcrumbs to use new item mixin

commit 90fc4ba
Author: Jan Faracik <[email protected]>
Date:   Wed Jun 15 18:57:51 2022 +0100

    Rename mixin

commit 28d0638
Merge: d1f42ac 65fcda1
Author: Jan Faracik <[email protected]>
Date:   Tue Jun 14 23:35:10 2022 +0100

    Merge branch 'master' into move-manage-jenkins-less

commit d1f42ac
Author: Jan Faracik <[email protected]>
Date:   Fri Jun 10 11:13:58 2022 +0100

    Update table.less

commit 13d5729
Author: Jan Faracik <[email protected]>
Date:   Thu Jun 9 10:03:01 2022 +0100

    Move from px to rem

commit 68f5425
Author: Jan Faracik <[email protected]>
Date:   Wed Jun 8 16:40:41 2022 +0100

    Update theme.less

commit 929e2d5
Author: Jan Faracik <[email protected]>
Date:   Wed Jun 8 16:28:06 2022 +0100

    Update mixins.less

commit 8c4b466
Merge: 8b22270 77a36fc
Author: Jan Faracik <[email protected]>
Date:   Wed Jun 8 16:27:25 2022 +0100

    Merge branch 'master' into move-manage-jenkins-less

commit 8b22270
Author: Jan Faracik <[email protected]>
Date:   Wed Jun 8 16:19:42 2022 +0100

    Update theme.less

commit e925490
Author: Jan Faracik <[email protected]>
Date:   Wed Jun 8 16:17:02 2022 +0100

    Add mixin for items

commit 494f551
Author: Jan Faracik <[email protected]>
Date:   Wed Jun 8 12:06:53 2022 +0100

    Fix url, add sidebar source

commit b3d74c4
Author: Jan Faracik <[email protected]>
Date:   Mon May 30 16:28:25 2022 +0100

    Fix imports

commit defecc6
Author: Jan Faracik <[email protected]>
Date:   Mon May 30 16:14:29 2022 +0100

    Update AboutJenkins.java

commit bc9a82b
Merge: 19587f6 d2e3468
Author: Jan Faracik <[email protected]>
Date:   Mon May 30 16:14:25 2022 +0100

    Merge branch 'master' into search-overhaul

commit 19587f6
Author: Jan Faracik <[email protected]>
Date:   Mon May 30 16:12:30 2022 +0100

    Remove another search index builder, correct icons

commit 3a07a15
Author: Jan Faracik <[email protected]>
Date:   Mon May 30 15:28:12 2022 +0100

    Add debounce, fix loading animation

commit 0c42352
Author: Jan Faracik <[email protected]>
Date:   Mon May 30 15:03:45 2022 +0100

    Fix not being able to close modal by clicking backdrop

commit 0037021
Author: Jan Faracik <[email protected]>
Date:   Mon May 30 14:55:29 2022 +0100

    Remove some search entries, make icons smaller

commit f89fe63
Merge: 1cb37d1 032a105
Author: Jan Faracik <[email protected]>
Date:   Thu May 26 20:18:41 2022 +0100

    Merge branch 'master' into new-plugin-manager-1

commit 9ef136f
Author: Jan Faracik <[email protected]>
Date:   Wed May 25 10:19:58 2022 +0100

    Get symbols working

commit 8b50d9e
Author: Jan Faracik <[email protected]>
Date:   Wed May 25 01:09:26 2022 +0100

    Fix scrolling

commit bdcb9b7
Author: Jan Faracik <[email protected]>
Date:   Wed May 25 00:30:56 2022 +0100

    Refactor using datasources

commit 684997d
Author: Jan Faracik <[email protected]>
Date:   Tue May 24 23:22:35 2022 +0100

    Refactor with ES6 classes

commit 4cb4af6
Author: Jan Faracik <[email protected]>
Date:   Mon May 23 21:16:14 2022 +0100

    Working build

commit 4c12763
Author: Jan Faracik <[email protected]>
Date:   Mon May 23 19:57:52 2022 +0100

    Remove keyboard shortcuts

commit c27db22
Merge: c58eb41 49f9f0c
Author: Jan Faracik <[email protected]>
Date:   Mon May 23 19:57:38 2022 +0100

    Merge branch 'master' into search-overhaul

commit d579dc5
Author: Jan Faracik <[email protected]>
Date:   Tue May 17 00:52:29 2022 +0100

    Update section.less

commit 43e4f5c
Author: Jan Faracik <[email protected]>
Date:   Tue May 17 00:29:22 2022 +0100

    Init

commit 1cb37d1
Author: Jan Faracik <[email protected]>
Date:   Thu Apr 28 17:23:38 2022 +0100

    Revert "Remove unused icon preload"

    This reverts commit 28aaf91.

commit 28aaf91
Author: Jan Faracik <[email protected]>
Date:   Thu Apr 28 17:20:41 2022 +0100

    Remove unused icon preload

commit dc8ba52
Author: Jan Faracik <[email protected]>
Date:   Thu Apr 28 12:07:35 2022 +0100

    Fix translucency on Firefox

commit 84596ee
Author: Jan Faracik <[email protected]>
Date:   Mon Apr 25 20:37:20 2022 +0100

    Update plugin-manager.less

commit cf28fee
Author: Jan Faracik <[email protected]>
Date:   Thu Apr 21 23:33:22 2022 +0100

    Add loading animation

commit addb738
Author: Jan Faracik <[email protected]>
Date:   Thu Apr 21 23:23:13 2022 +0100

    Finish

commit 53902db
Author: Jan Faracik <[email protected]>
Date:   Thu Apr 21 23:02:08 2022 +0100

    Update sidebar

commit b8a622c
Author: Jan Faracik <[email protected]>
Date:   Thu Apr 21 22:43:32 2022 +0100

    Init

commit c58eb41
Author: Jan Faracik <[email protected]>
Date:   Fri Mar 25 14:27:13 2022 +0000

    Update keyboard shortcut logic

commit b330661
Author: Jan Faracik <[email protected]>
Date:   Thu Mar 24 23:15:30 2022 +0000

    Initial commit, working search overlay
@janfaracik
Reset
39589a3
@janfaracik
Simplify
22d83a7
@janfaracik
Fix urls
cbc13a7
@janfaracik
Polish
a240f54
@janfaracik
Fix keyboard nav
654d71e
@janfaracik
Merge branch 'master' into command-palette
065e979
@janfaracik
Fix help link
5048640
@timja timja added the web-ui The PR includes WebUI changes which may need special expertise label Jan 6, 2023
@github-actions github-actions bot added the unresolved-merge-conflict There is a merge conflict with the target branch. label Apr 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2023

Please take a moment and address the merge conflicts of your pull request. Thanks!

@github-actions github-actions bot removed the unresolved-merge-conflict There is a merge conflict with the target branch. label Apr 6, 2023
@janfaracik janfaracik mentioned this pull request Apr 6, 2023
Closed
@janfaracik janfaracik marked this pull request as ready for review April 9, 2023 10:22
@janfaracik janfaracik changed the title draft: Overhaul search with a Command Palette Overhaul search with a Command Palette Apr 9, 2023
@github-actions github-actions bot added the unresolved-merge-conflict There is a merge conflict with the target branch. label Apr 21, 2023
@github-actions
Copy link
Contributor

Please take a moment and address the merge conflicts of your pull request. Thanks!

@github-actions GitHub Actions
Copy link
Contributor

Please take a moment and address the merge conflicts of your pull request. Thanks!

@github-actions github-actions bot removed the unresolved-merge-conflict There is a merge conflict with the target branch. label Jul 22, 2024
@mawinter69
Copy link
Contributor

I created JENKINS-73564 to track removal of YUI from the searchbox which this PR accomplishes

@timja
Copy link
Member

timja commented Aug 13, 2024

@daniel-beck are you able to take another look please?

@daniel-beck
Copy link
Member

Sorry for the delay here. With Java EE over, I plan to look at this in the next few days.

@judovana
Copy link

hi!

Just pelase keep the old search around. There is only few plugins overriding it, but those have usually purpose. The old search can be done pretty powerful. The command palette and full search are two different things. With full search, you can search in job names, in build-ids, in artifacts (similar to full searches in IDE's projecs). With command pallete you should search in "waht this tool do" - manage nodes, manage jobs. manage plugins.... Those two things have small intersections, but otherwise should be kept separated.

My irrelevant $0.002

@daniel-beck
Copy link
Member

@judovana

Just pelase keep the old search around

Could you clarify whether the current state, which retains the /search/ URL and allows navigating there, does that? Is the problem that out of the box, there is no longer an entrypoint to get there? The proposed change to lucene-search basically adds a link there.

(IMO there are some limitations to how "search" behaves at the moment which makes it pretty awkward. E.g., it only supports a single Search subclass to handle the URL for a given SearchableModelObject. Having nested-view, lucene-search, and search-all-results-plugin installed at the same time isn't a good search experience, one of them simply wins. The extension point seems intended to override the search experience for a single specific SearchableModelObject rather than having multiple plugins contribute to search, globally.

This is another indicator that the current "search" really was intended as just (or perhaps primarily) a launcher.

jenkins/core/src/main/java/hudson/search/package-info.java

Lines 25 to 28 in 2d2adef

/**
* <a href="https://qsapp.com/">QuickSilver</a>-like search/jump capability for better navigation around Jenkins.
*/
package hudson.search;
is kinda authoritative, originally added in 2007.)

(FWIW I started looking into this again, noticing other implementations, e.g., nested-view, which led me to the detour #9737.)

@github-actions github-actions bot added the unresolved-merge-conflict There is a merge conflict with the target branch. label Oct 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

Please take a moment and address the merge conflicts of your pull request. Thanks!

@github-actions github-actions bot removed the unresolved-merge-conflict There is a merge conflict with the target branch. label Oct 12, 2024
@timja timja requested a review from mawinter69 November 1, 2024 16:44
@timja
Copy link
Member

timja commented Nov 6, 2024

@daniel-beck this looks to be the last remaining blocker for removing yui, have you got any outstanding feedback?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timja timja timja approved these changes

@Wadeck Wadeck Awaiting requested review from Wadeck

@NotMyFault NotMyFault Awaiting requested review from NotMyFault

@daniel-beck daniel-beck Awaiting requested review from daniel-beck

@mawinter69 mawinter69 Awaiting requested review from mawinter69

Assignees
No one assigned
Labels
ath-successful This PR has successfully passed the full acceptance-test-harness suite rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted security-approved @jenkinsci/core-security-review reviewed this PR for security issues web-ui The PR includes WebUI changes which may need special expertise
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@janfaracik @timja @NotMyFault @Kevin-CB @daniel-beck @zbynek @mawinter69 @judovana @Wadeck